Skip to content

Conversation

@stolarczyk
Copy link
Member

@stolarczyk stolarczyk commented May 1, 2019

No description provided.

@stolarczyk stolarczyk requested a review from nsheff May 1, 2019 13:10
@stolarczyk
Copy link
Member Author

BiocCheck passed

@nsheff
Copy link
Contributor

nsheff commented Sep 30, 2020

looks great! can you make sure it passes unit tests?

@stolarczyk
Copy link
Member Author

this is probably not valid anymore since we've made lots of changes to the piface spec recently

@nsheff
Copy link
Contributor

nsheff commented Oct 1, 2020

what exactly is not valid anymore? You mean we need to update BiocProject to accommodate the new piface spec?

@stolarczyk
Copy link
Member Author

yes

@stolarczyk stolarczyk changed the title v0.2.1 v0.2.2 Oct 13, 2020
@stolarczyk stolarczyk marked this pull request as draft October 13, 2020 23:48
@nsheff
Copy link
Contributor

nsheff commented Oct 22, 2020

minor thing, probably worth a full version bump to 0.3.0 at least right?

@stolarczyk
Copy link
Member Author

yeah right

@stolarczyk stolarczyk changed the title v0.2.2 v0.3.0 Oct 22, 2020
@nsheff
Copy link
Contributor

nsheff commented Sep 24, 2021

@stolarczyk if you have a minute, can you give a quick update as to where things stand with this PR? Is there anything still pending here? I can't see from the notes

@stolarczyk
Copy link
Member Author

I think it's up to date. I suggest to test it in action before release and make sure the most recent versions of pipeline interface and pipestat output schema are used.

@stolarczyk stolarczyk marked this pull request as ready for review October 11, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants